Sk1erLLC / Patcher

A Forge mod full of Vanilla bug fixes, Quality of Life improvements, and performance enhancements.
Other
228 stars 59 forks source link

Slow world swapping #161

Open gepbird opened 11 months ago

gepbird commented 11 months ago

I feel like with Optimized World Swapping enabled, changing worlds was pretty fast before, but now it feels slower.

I did some benchmarks (1 minute warmup), by checking how much time does it take to change worlds on Hypixel from sending a /hub command and seeing the first entity/chunk appear, here are the results:

With render distance 2:

With render distance 12:

With render distance: 32:

On normal render distance, Patcher is more than 2x faster than vanilla, but on 32 render distance, Patcher is actually slower than vanilla, how?? My only guess is forge slows down world loading. AxolotlClient stays fast no matter the render distance. I wonder if it's possible to implement that speed up on forge too.

Some other information about the benchmark and my system:

Sychic commented 11 months ago

I'm unable to reproduce these results. The main things that patcher does is remove the loading screen and prevent a garbage collector call to make world swapping faster.

gepbird commented 11 months ago

@Sychic How long does it take you to switch worlds in vanilla vs with Patcher? (and if they are slower than ~600ms, can you check it with AxolotlClient too?)

Sychic commented 11 months ago

It takes me under a second for both so I'm unable to notice too much of a difference however vanilla is noticeably slower.