Improving library performance

[Skelmis]

I'm looking to create a list here of things that currently 'exist' but definitely have better ways of doing things which could lead to a noticable increase in speeds

• 1 Currently we clean the users message cache upon every message that is checked against them. However, it would be nice for performance reasons to cleanup both user and guild objects if they serve no purpose. For example, if a guild has one user attached, and that user no longer has any valid messages they can all be safely deleted.

Given the nature of threading and locks within the library currently and how poorly they have faired in the past, I might look to outsource this as a public method which the user has the option to call themselves until future notice.

• 2 Checking against objects can be more efficient, creating a new object before looping over every stored object to figure out if one exists. This is O(n) at worst in terms of time and also creates excess objects. Which can easily lead to slowdown for bots with lots of guilds. This could be supplemented a little with the addition of item 1, but that only applies to inactive guilds.

An ideal solution would not create any objects and be under O(n), currently however I am considering abstracting away all current storage objects into abc classes which merely have the dunder methods and the data required for them. This would allow for somewhat lighter weight comparisons and also might help to cleanup the classes in the library a bit

These are the only couple off my head now, however I would appreciate anything other developers have to contribute.

[Skelmis]

• Base classes not abstract interfaces

[Skelmis]

Another comment on 1 We should add the option for how long User objects should be persisted. They should be persisted so punishments carry over between kicks, however, if they get banned it can be assumed we can wipe their data. Don't think ill force the ban wipe, however, definitely having some form of logging to maintain whether or not a User can be cleaned up would be nice.

Programmatic view for if a User can be wiped:

• They have no stored Message's
  • They also don't have an outstanding kick/warn from within x
• They were kicked/banned over x time ago, where x is a settable option x as a general rule should be somewhat high, to avoid cleaning up User's who have got outstanding warns/kicks This cleanup will also only be a manual call, for those who want to cleanup things. It will not be forced at this time unless performance comes to the forefront as an issue

Programmatic view for if a Guild can be wiped:

• They have no stored User's

I think thats it?

[Skelmis]

The above should be profiled to see if its actually making a difference or not however..

[Skelmis]

Closing for now