Replace update-version task with release-commit

[rickmak]

Updated

On 5 January 2018 at 11:35, Kwok-kuen Cheung notifications@github.com wrote:

@cheungpat requested changes on this pull request.

In Makefile https://github.com/SkygearIO/py-skygear/pull/178#discussion_r159802507:

@@ -27,7 +20,7 @@ docker-build: build docker-push: make -C scripts/docker-images/release docker-push

-.PHONY: update-version -update-version:

• $(SED) "s/version='.*'/version='$(PACKAGE_VERSION)'/" setup.py
• $(SED) "s/version = '.*'/version = '$(PACKAGE_VERSION)'/" skygear/version.py

• +.PHONY: release-commit

make update-version is called in travis

let’s keep update-version?

In scripts/release-commit.sh https://github.com/SkygearIO/py-skygear/pull/178#discussion_r159802539:

@@ -0,0 +1,26 @@ +if [ -z "$SKYGEAR_VERSION" ]; then

need #!/bin/sh -e here

In scripts/release-commit.sh https://github.com/SkygearIO/py-skygear/pull/178#discussion_r159802691:

+if [ -z "$SKYGEAR_VERSION" ]; then

• &2 echo "SKYGEAR_VERSION is required."

• exit 1 +fi +if [ -z "$GITHUB_TOKEN" ]; then

• &2 echo "GITHUB_TOKEN is required."

• exit 1 +fi +if [ -z "$KEY_ID" ]; then

• &2 echo "KEY_ID is required."

• exit 1 +fi +if [ -e "new-release" ]; then
• echo "Making release commit and github release..." +else
• echo "file 'new-release' is required."

need to add >&2 here

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SkygearIO/py-skygear/pull/178#pullrequestreview-86813932, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD01cys_3_blyi_xncx0obCQbnqGJ6gks5tHZhmgaJpZM4RTCOF .

-- Rick Mak | Software Engineer | CC81327D Oursky.com | rickmak@oursky.com | 852-96205080