Skyrat-SS13 / Skyrat-tg

A Skyrat downstream of /tg/station SS13.
GNU Affero General Public License v3.0
121 stars 688 forks source link

Unusual Reaction behavior with spilled reagents #22300

Open Samarai opened 1 year ago

Samarai commented 1 year ago

Reporting client version: 514.1589

Round ID:

8843

Testmerges:

Reproduction:

When there are multiple spilled reagents on the same tile, be it a pool floor or regular tile, it is very inconsistent as to what happens if said reagents would react, given their current temperature and state allows it. Reagents may simply not react, or only react partially. These reagents will then react as normal if scooped into a beaker or soaked into a mop, which can have disastrous results. (EX: Sonic Powder/Flash Powder being mixed upon an unsuspecting janitor trying to mop up an otherwise safe spill)

A super simple way to reproduce this issue is to simply use two reagents that react at room temperature, like many bar recipes, or space ants and sugar.

Screenshot (3807)

vinylspiders commented 1 year ago

Was it always like this? Or is this a more recent event (and if so can you recall around how long ago it started)?

Samarai commented 1 year ago

Was it always like this? Or is this a more recent event (and if so can you recall around how long ago it started)?

No clue whatsoever, I'm sorry. My gut tells me it's always been like this, but I have zero actual evidence for such.

vinylspiders commented 1 year ago

Was it always like this? Or is this a more recent event (and if so can you recall around how long ago it started)?

No clue whatsoever, I'm sorry. My gut tells me it's always been like this, but I have zero actual evidence for such.

All good--either way, this is definitely a bug! A cursory glance tells me that it will probably require some considerable studying of liquids so probably don't count on a fix for a bit.

YakumoChen commented 1 year ago

Liquid code was a mistake It's been like this forever and liquids as a whole do not play nice with chemistry.