Skyrat-SS13 / Skyrat-tg

A Skyrat downstream of /tg/station SS13.
GNU Affero General Public License v3.0
122 stars 685 forks source link

[MIRROR] Fix Tongue Based Speech Modifiers Being Applied To Users Native Languages #28854

Closed SkyratBot closed 1 month ago

SkyratBot commented 1 month ago

Original PR: https://github.com/tgstation/tgstation/pull/84952

About The Pull Request

This change allows tongue based speech modifications to be ignored if the user is speaking in a native language or using hand signs, putting it back to where it was functionally before moving to speechmod components.

Why It's Good For The Game

This is correcting some of the speaking code to how it was working prior to speechmods, meaning lizard people won't be elongating there s's in draconic. Fly people are the other species with a tongue based speech modifier and receive the same fix. This also corrects tongue based speech mods getting applied to sign language. Speech modifiers are still applied if the user is talking in a non-native language, same as it was pre speechmod.

Before: speechmod_demo_before After: speechmod_demo_after

Changelog

:cl: fix: fixing speech modifiers being applied to a tongue's native languages. /:cl: