The loadout PR changed it so the assistant's loadout preview used an outfit called "Assistant - Consistent" to keep it a consistent grey, only issue is that the consistent outfit does not consider the user's suit preference so it'd stay as a grey jumpsuit even if skirts were preferred, this PR adds a new assistant outfit called "Assistant - Preview" to be used for loadout previews.
I opted against adding the suit check to the consistent outfit instead since as far as I can see it is meant to stay at a consistent grey suit for mob spawns, icons and unit tests and that could end up creating more issues otherwise.
It fixes an issue where only assistant jumpsuits were shown on the character preview if you have assistant selected to on, regardless of your suit preferences.
Changelog
:cl: Hardly3D
fix: Added a preview assistant outfit, allowing assistant jumpskirts to be previewed again on character preferences.
/:cl:
Original PR: https://github.com/tgstation/tgstation/pull/84861
About The Pull Request
The loadout PR changed it so the assistant's loadout preview used an outfit called "Assistant - Consistent" to keep it a consistent grey, only issue is that the consistent outfit does not consider the user's suit preference so it'd stay as a grey jumpsuit even if skirts were preferred, this PR adds a new assistant outfit called "Assistant - Preview" to be used for loadout previews.
I opted against adding the suit check to the consistent outfit instead since as far as I can see it is meant to stay at a consistent grey suit for mob spawns, icons and unit tests and that could end up creating more issues otherwise.
https://github.com/tgstation/tgstation/assets/66234359/502cd0c5-ec51-43bf-bbc2-6f5435047d2a
Fixes https://github.com/tgstation/tgstation/issues/83908
Why It's Good For The Game
It fixes an issue where only assistant jumpsuits were shown on the character preview if you have assistant selected to on, regardless of your suit preferences.
Changelog
:cl: Hardly3D fix: Added a preview assistant outfit, allowing assistant jumpskirts to be previewed again on character preferences. /:cl: