search

Skyscanner / aiotask-context

Contextual information for asyncio tasks
MIT License
161 stars 25 forks source link

Adds copying_task_factory and tests #13

Closed Aeory closed 6 years ago

Aeory commented 7 years ago

The copying_task_factory does not share the context when creating new tasks and uses a copy of it. This is to allow created tasks to modify their context without mirroring the change into every other task, but whilst still passing along a copy of their own context to their children.

argaen commented 7 years ago

LGTM! @pfreixes any comments? If not tomorrow I'll merge :)

pfreixes commented 7 years ago

@Aeory will be nice if you can update the README.md with this new feature.

argaen commented 6 years ago

Hi @Aeory, any intentions on applying latest changes? :)

Aeory commented 6 years ago

Heu @argaen, sorry for the delay. I've made changes, rebased and pushed. Let me know if you want anything else.

argaen commented 6 years ago

other than minor comment, LGTM. @pfreixes has to approve changes

pfreixes commented 6 years ago

LGTM! go ahead