SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
269 stars 463 forks source link

fp2: add lowercase search parameter #1717

Closed hdlee27 closed 1 month ago

hdlee27 commented 1 month ago

Check all that apply

Type of Change

Checklist

Description of Change

The mDNS service name of the actual Aqara FP2 is “_Aqara-FP2. _tcp".

if the search parameter is "_Aqara-FP2. _tcp", the driver is executed in V3 and SmartThings Station, but not in the hub on the monitor. if the search parameter is "_aqara-fp2. _tcp", the driver is executed in the hub on the monitor, but not in V3 and SmartThings Station. if the search parameter contains both “_Aqara-FP2. _tcp” and “_Aqara-fp2. _tcp”, the driver runs well in both v3, station, and hub on the monitor.

Summary of Completed Tests

complete fp2 registration test on hub on monitor M5, v3, smartthings station

github-actions[bot] commented 1 month ago

Channel deleted.

github-actions[bot] commented 1 month ago

Test Results

   64 files    400 suites   0s ⏱️ 1 989 tests 1 989 ✅ 0 💤 0 ❌ 3 429 runs  3 429 ✅ 0 💤 0 ❌

Results for commit 2d0cf9ab.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 2d0cf9ab522c22ee32baa5969fe6d1c73cf34d7b

ldeora commented 1 month ago

That actually worked,

Added 2 out of 3 aqara FP2’s pretty instant , logs are flowing about discovery as well, will check whats wrong about the 3rd one. Thanks


Great news! It works!

I can confirm that all I did was install the driver on the hub then added it using the normal add accessory process. I did not have to remove/reset etc. the device to have it successfully enrolled into ST.

Chefs Kiss!

https://community.smartthings.com/t/aqara-fp2-cannot-be-discovered-in-smartthings-tv-hub-and-mesh-network/289483/35?u=andreas_roedl

ldeora commented 1 month ago

Works for V3, TV hubs but allegedly not for V2:

https://community.smartthings.com/t/aqara-fp2-cannot-be-discovered-in-smartthings-tv-hub-and-mesh-network/289483/43?u=andreas_roedl

(Conversation between tryinto... and Andreas)

Confirmed that driver from this PR is installed. No logcat output from driver. Hub is V2, 54.13.