SmashPhil / Vehicle-Framework

Core mod for Vehicles
Other
57 stars 30 forks source link

[CompVehicleLauncher] Flying vehicles with zero cargo capacity should be over encumbered #189

Open awgv opened 3 months ago

awgv commented 3 months ago

Hello,

It would be great to add an additional check to prevent vehicles with zero cargo capacity from being able to launch. This request comes from how VF separates cargo capacity and passengers—I ended up using cargo capacity as currency for upgrades; you can upgrade a vehicle with cargo capacity or increased passenger slots, but passenger upgrades decrease cargo capacity.

If I load anything into a vehicle with zero cargo capacity, a vehicle will become over encumbered, but if I load no cargo and some passengers, I’ll still be able to launch, which doesn’t make sense to me balance-wise. We could expose an XML property to allow controlling the behavior, but personally, I don’t see the use case where a vehicle can launch with zero cargo capacity.

https://github.com/SmashPhil/Vehicle-Framework/blob/523cb1a9be9169a35ac2537e70db576f9a38293b/Source/Vehicles/Comps/Flyer/Launching/CompVehicleLauncher.cs#L180-L184