Smile-SA / elasticsuite

Smile ElasticSuite - Magento 2 merchandising and search engine built on ElasticSearch
https://elasticsuite.io
Open Software License 3.0
763 stars 342 forks source link

Amend require section of composer.json with maximum compatibility version #2023

Open mamsincl opened 3 years ago

mamsincl commented 3 years ago

Is your feature request related to a problem? Please describe. During and (especially) after Magento upgrade (via composer) the incompatibility with the previous Elasticsuite version could cause unexpected behaviour. Debugging the issue could be time-consuming and may result custom patches and unnecessary PRs

Describe the solution you'd like Extend compatible version with maximum version in require section of composer.json

Describe alternatives you've considered We can call the beginning of README as an alternative solution already exists

Additional context example for version 2.9.x (compatible with Magento >=2.3.5 <2.4.0 - linking to magento/framework should be enough):

"require": {
        "magento/framework": ">=102.0.5 <103.0.0",
        "magento/module-store": ">=101.0.5",
        "magento/module-backend": ">=101.0.5",
        "magento/module-catalog": ">=103.0.5",
        "magento/module-catalog-search": ">=101.0.5",
        "magento/module-catalog-graph-ql": ">=100.3.5",
        "magento/module-inventory-sales-api": ">=1.0.3",
        "magento/module-inventory-sales": ">=1.0.3",
        "magento/module-inventory-indexer": ">=1.0.3",
        "magento/magento-composer-installer": "*",
        "elasticsearch/elasticsearch": "~6.7|~7.2"
    },
romainruaud commented 3 years ago

Yep, I do agree with this, it would also save us some time answering on "invalid" issues here that are due to misfits with maximum supported versions.

mamsincl commented 3 years ago

I'll see if I can spare some time to help with this ... Can you advise on the best approach of MRs?

romainruaud commented 3 years ago

@mamsincl you can propose a PR to 2.9.x and 2.10.x branch

Regards