search

Smile-SA / elasticsuite

Smile ElasticSuite - Magento 2 merchandising and search engine built on ElasticSearch
https://elasticsuite.io
Open Software License 3.0
763 stars 342 forks source link

Uninstall script missing eav_attribute column #3390

Open vseager opened 2 months ago

vseager commented 2 months ago

The module adds a sort_direction column to eav_attribute but this isn't included in the uninstall script:

https://github.com/Smile-SA/elasticsuite/blob/2f54d2492a398253a6a4add3ef2e6fb9d5c12819/src/module-elasticsuite-catalog/Setup/CatalogSetup.php#L149-L156 https://github.com/Smile-SA/elasticsuite/wiki/ModuleUninstall

Preconditions

Latest version

Steps to reproduce

  1. Install latest version of Elasticsuite
  2. Uninstall Elasticsuite and run SQL commands: https://github.com/Smile-SA/elasticsuite/wiki/ModuleUninstall

Expected result

  1. You can edit categories in the admin

Actual result

  1. Can't edit categories in Magento admin
ReflectionException: Class "Smile\ElasticsuiteCatalog\Model\Category\Attribute\Source\SortDirection" does not exist in /vendor/magento/framework/Code/Reader/ClassReader.php:34
ablary-silicon commented 2 months ago

same problem on my environment

vahonc commented 2 months ago

Hi guys,

You need to perform this command: DELETE FROM eav_attribute where attribute_code='sort_direction';

Thanks for your feedback, I'll update the UnInstall commands in our Wiki.

BR, Vadym