Smithsonian / layup

Orbit fitting at LSST scale
MIT License
1 stars 1 forks source link

write function to do checks on observations and identify if there's a problem with the input astrometry before sending it on the C++ code for fitting #181

Closed mschwamb closed 2 weeks ago

mschwamb commented 2 weeks ago

We want a function that would look at d structure before observation structure is populated in https://github.com/Smithsonian/layup/blob/97bdfe1ea32e74b726ee5d8ba08f935d2833931f/src/layup/orbitfit.py#L49

the function should return a bool value true if orbitfit should proceed or not actually call the orbitfit a fail and skip sending on to the C++ code and set the success flag to be a failure so the output is all nans in the orbit parameters data structure other than objectID (related to #180)

Conditions when we should not sent on to the C++ orbit fitting code:

mschwamb commented 2 weeks ago

proposal we issue flag of -1 if the fit fails because the input is bad (the above conditions cause failures)