search

Snapchain / op-chain-deployment

2 stars 1 forks source link

Chore: Add CI to check ENV conflicts #20

Closed bournezjc closed 1 month ago

bournezjc commented 1 month ago

Summary

This pr adds a CI to check environment variable conflicts in .env & .env.explorer

Test

Pass screenshot (.env.example vs .env.explorer.example) image

Not pass screenshot (.env.explorer.example vs .env.bridge.example) image

bournezjc commented 1 month ago

I am not sure which two files should be compared here. Any comments?

bap2pecs commented 1 month ago

I am not sure which two files should be compared here

the idea is to compare the 3 files at once. you can iterate thru each one and put the keys in a "set" and throw if there is another key with same name.

Not pass screenshot (.env.explorer.example vs .env.bridge.example)

good find. can you also fix that? so instead of copying and replacing the env in scripts/l2-bridge/l2-bridge-set-env.sh, we should directly set it in .env.bridge in scripts/l2-bridge/l2-bridge-deploy-l1-multicall.sh

bournezjc commented 1 month ago

Currently I have built a CI that only alerts if env conflicts. Besides CI, another task is to implement a fix solution in scripts, am I right?

bap2pecs commented 1 month ago

another task is to implement a fix solution in scripts, am I right?

yes but you can do it in this same PR so it will test CI altogether with it