search

SnowShock35 / jei-integration

Providing Integrations & Tooltips
https://curseforge.com/minecraft/mc-mods/jei-integration
MIT License
9 stars 13 forks source link

tagsTooltipMode breaks when nbtTooltipMode is disabled #8

Closed WenXin20 closed 3 years ago

WenXin20 commented 3 years ago

Minecraft v1.16.4 Forge v35.1.13 JEI Integration v6.1.1.11

The config doesn't seem to work. By default, it shows everything is disabled, by when in-game, I still see all the tooltips. And changing the tags to display 'onShift' doesn't work either.

WenXin20 commented 3 years ago

It also seems like tags will only show if nbt tooltip is also enabled with Forge v35.1.36.

GeekJokes commented 3 years ago

Not really the same problem but i guess it's similar: the setting for tags doesnt really give me any tags, just "ID:minecraft:iron_ingot" for example, instead of the forge:ingot and such

James-E-A commented 3 years ago

It's working fine for me on

2021-01-14_14 03 08 2021-01-14_14 03 12

James-E-A commented 3 years ago

To enable this, you have to go into .minecraft/config/jeiintegration-client.toml and set

[tooltip_options]

    # Configure tooltip for NBT data.
    nbtTooltipMode = "enabled"
WenXin20 commented 3 years ago

I know that works, but what I mean is that I want to disable nbt and enable tags only, but tags do not show unless nbt is enabled.

James-E-A commented 3 years ago

I don't think I can confirm this bug, then.

[tooltip_options]
    # Configure tooltip for burn time.
    burnTimeTooltipMode = "disabled"
    # Configure tooltip for registry name. E.g. minecraft:stone
    registryNameTooltipMode = "disabled"

    # Configure tooltip for NBT data.
    nbtTooltipMode = "disabled"

    # Configure tooltip for translation key. E.g. block.minecraft.stone
    translationKeyTooltipMode = "disabled"
    # Configure tooltip for max stack size.
    maxStackSizeTooltipMode = "disabled"

    # Configure tooltip for tags. E.g. forge:ingot, minecraft:planks
    tagsTooltipMode = "enabled"

    # Configure tooltip for durability.
    durabilityTooltipMode = "disabled"
    # Configure tooltip for hunger and saturation.
    foodTooltipMode = "disabled"

2021-01-14_14 45 38 2021-01-14_14 45 40

WenXin20 commented 3 years ago

Well, that is what happens in my case. Have you tried with Forge v35.1.36? That's the version that this happens for me.

James-E-A commented 3 years ago

35.1.4 is still the latest recommended version. Consider installing that.

(I cannot, however, reproduce this on 35.1.36, either:)

2021-01-14_15 06 01

PEBCAK? Check your config file…

James-E-A commented 3 years ago

Actually, upon further testing, I can confirm this, even on the Recommended forge version.

@SnowShock35

Before enabling nbtTooltipMode

2021-01-14_15 21 072021-01-14_15 21 12

After enabling nbtTooltipMode

2021-01-14_15 24 082021-01-14_15 24 11

WenXin20 commented 3 years ago

Yep. That's what I'm seeing too. With Forge versions, I think I have a mod or two that requires a later version.

James-E-A commented 3 years ago

@WenXin20 consider changing the title to "tagsTooltipMode breaks when nbtTooltipMode is disabled" or something like that?

WenXin20 commented 3 years ago

Oh, sure.

SnowShock35 commented 3 years ago

Hey sorry, I've not looked at this sooner been really hectic. Is this still an issue with the latest version of both Forge and JEI Integration?

WenXin20 commented 3 years ago

Yep, it still happens

SnowShock35 commented 3 years ago

Okay, I will take a look when I get a chance. Really hectic with my thesis at the moment, but I'll try get back to it soon.

WenXin20 commented 3 years ago

Alright, no problem