Snowflake-Labs / schemachange

A Database Change Management tool for Snowflake
Apache License 2.0
517 stars 229 forks source link

Format with black #217

Closed zanebclark closed 4 months ago

zanebclark commented 10 months ago

I've added the black formatter to the pre-commit hooks along with the flake8 linter. I addressed the issues raised by these tools along with some formatting and type hint errors. The functionality of the script should be the same. The development experience should be a bit nicer.

sfc-gh-twhite commented 4 months ago

Thank you for opening this, @zanebclark! I apologize, we have been behind on many of these PRs and Issues and are trying to catch up.

Many of these formatting changes had been on our roadmap and have been taken care of elsewhere since then. I do think that there are portions of this we would like to use, particularly exploring flake8 and some of the type annotation work; once we fold in some of the other upstream changes, I would like to include this one as well.