search

Snowflyt / typora-copilot

GitHub Copilot plugin for Typora on both Windows, macOS and Linux, provided through Copilot.vim.
https://github.com/Snowflyt/typora-copilot
MIT License
71 stars 5 forks source link

MacOS bugfix #2

Closed evaldsurtans closed 8 months ago

evaldsurtans commented 10 months ago

for macos change

yield runShellCommand(command);

to

runShellCommand(command);

then it works

evaldsurtans commented 10 months ago

Great plugin and clean code, thank you, happy if you add me to Git as contributor or will make fork and pull requests

Snowflyt commented 10 months ago

I‘d welcome a PR on that. The await in the code seems superfluous and could be omitted. I haven't experienced any related issues on my MacBook Pro M2, so it might be a compatibility problem unique to certain devices.

Also, our repository's commitlint might be somewhat strict, adhering to the standards of the VSCode git-commit-plugin, which could aid you in making your PR submission more seamless :)

Snowflyt commented 8 months ago

Fixed in 267c1e18e56008f5c30834abb9eaa7daba0603fa.