search

Soapbox / laravel-formatter

A Formatter Class for Laravel 4 based on FuelPHP's Formatter Class
249 stars 95 forks source link

Facade implementation #16

Closed sirsquall closed 9 years ago

sirsquall commented 9 years ago

Update the ServiceProvider, and create a Facades to be used by laravel.

Jaspaul commented 9 years ago

Hey @sirsquall thanks for the contribution. Sorry it took so long to get back to you.

I noticed that you made the constructor on Formatter.php public. Also you've allowed the construction of the Formatter object with a null parser. This makes the implication that the following is valid usage of the library (new Formatter())->toJson();. Doing this however will not work, and will give errors.

Jaspaul commented 9 years ago

Also, there's an included phpunit testsuite that you can run to see if your changes will break something other's might be relying on. =)

Jaspaul commented 9 years ago

Closing this pull request as it appears to have been abandoned. Feel free to open it up again once the tests are passing.

To run the tests you can use the following command: phpunit