search

SocialGouv / domifa

Faciliter l'accès aux droits pour les personnes sans domicile stable, en simplifiant la gestion de la domiciliation
https://domifa.fabrique.social.gouv.fr
Apache License 2.0
14 stars 10 forks source link

fix(backend): fix statut when you delete an usager #3453

Closed pYassine closed 3 months ago

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.46%. Comparing base (6fa8b47) to head (fc60f41). Report is 2 commits behind head on master.

Files Patch % Lines
...ages/backend/src/auth/guards/AppUserGuard.guard.ts 66.66% 1 Missing :warning:
...es/backend/src/usagers/services/usagers.service.ts 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453/graphs/tree.svg?width=650&height=150&src=pr&token=ydhKiPXRFO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv)](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ```diff @@ Coverage Diff @@ ## master #3453 +/- ## ========================================== - Coverage 66.47% 66.46% -0.01% ========================================== Files 922 922 Lines 15214 15216 +2 Branches 2130 2155 +25 ========================================== + Hits 10113 10114 +1 + Misses 5061 4809 -252 - Partials 40 293 +253 ``` | [Files](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | Coverage Δ | | |---|---|---| | [...in-structures/services/admin-structures.service.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_portail-admin%2Fadmin-structures%2Fservices%2Fadmin-structures.service.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX3BvcnRhaWwtYWRtaW4vYWRtaW4tc3RydWN0dXJlcy9zZXJ2aWNlcy9hZG1pbi1zdHJ1Y3R1cmVzLnNlcnZpY2UudHM=) | `98.51% <ø> (ø)` | | | [packages/backend/src/auth/auth.module.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fauth%2Fauth.module.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvYXV0aC9hdXRoLm1vZHVsZS50cw==) | `100.00% <ø> (ø)` | | | [...usagers/controllers/usagers-decision.controller.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fusagers%2Fcontrollers%2Fusagers-decision.controller.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvdXNhZ2Vycy9jb250cm9sbGVycy91c2FnZXJzLWRlY2lzaW9uLmNvbnRyb2xsZXIudHM=) | `43.10% <ø> (ø)` | | | [...kend/src/usagers/controllers/usagers.controller.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fusagers%2Fcontrollers%2Fusagers.controller.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvdXNhZ2Vycy9jb250cm9sbGVycy91c2FnZXJzLmNvbnRyb2xsZXIudHM=) | `64.92% <ø> (ø)` | | | [...ages/backend/src/auth/guards/AppUserGuard.guard.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fauth%2Fguards%2FAppUserGuard.guard.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvYXV0aC9ndWFyZHMvQXBwVXNlckd1YXJkLmd1YXJkLnRz) | `94.11% <66.66%> (-2.76%)` | :arrow_down: | | [...es/backend/src/usagers/services/usagers.service.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fusagers%2Fservices%2Fusagers.service.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvdXNhZ2Vycy9zZXJ2aWNlcy91c2FnZXJzLnNlcnZpY2UudHM=) | `32.55% <0.00%> (ø)` | | ... and [122 files with indirect coverage changes](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Last update [6fa8b47...fc60f41](https://app.codecov.io/gh/SocialGouv/domifa/pull/3453?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv).
github-actions[bot] commented 3 months ago

🎉 Deployment for commit fc60f4168345178c51c11ad76c6585e3c710b112 :

Ingresses - 🚀 [https://admin-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/](https://admin-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/) - 🚀 [https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/](https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/) - 🚀 [https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/admin/structures/export](https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/admin/structures/export) - 🚀 [https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/export](https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/export) - 🚀 [https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/stats](https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/stats) - 🚀 [https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/stats/home](https://api-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/stats/home) - 🚀 [https://domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/](https://domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/) - 🚀 [https://mon-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/](https://mon-domifa-fix-update-statut-usager.ovh.fabrique.social.gouv.fr/)
Docker images - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-fc60f4168345178c51c11ad76c6585e3c710b112 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-fc60f4168345178c51c11ad76c6585e3c710b112 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-fc60f4168345178c51c11ad76c6585e3c710b112 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-fc60f4168345178c51c11ad76c6585e3c710b112
Debug - [📕 Loki logs for namespace domifa-fix-update-statut-usager](https://grafana-ovh.fabrique.social.gouv.fr/explore?orgId=1&left=%5B%22now-6h%22,%22now%22,%22Loki%22,%7B%22expr%22:%22%7Bnamespace%3D%5C%22domifa-fix-update-statut-usager%5C%22%7D%22%7D%5D) - [📈 Pods monitoring for namespace domifa-fix-update-statut-usager](https://grafana-ovh.fabrique.social.gouv.fr/d/a7df53d7-0696-4e00-821b-c56b66e5c20a/kubernetes-compute-resources-namespace-pods?orgId=1&refresh=10s&var-datasource=P5DCFC7561CCDE821&var-cluster=ovh-dev&var-namespace=domifa-fix-update-statut-usager) - [📈 Workloads monitoring for namespace domifa-fix-update-statut-usager](https://grafana-ovh.fabrique.social.gouv.fr/d/a164a7f0339f99e89cea5cb47e9be617V2/kubernetes-compute-resources-namespace-workloads?orgId=1&refresh=10s&var-datasource=eb239be0-0ac2-41d5-9e1a-061f951a07a3&var-cluster=ovh-dev&var-namespace=domifa-fix-update-statut-usager&var-type=deployment) - [🐘 CNPG pg](https://grafana-ovh.fabrique.social.gouv.fr/d/z7FCA4Nn1/cloudnativepg?orgId=1&refresh=30s&var-DS_PROMETHEUS=default&var-namespace=domifa-fix-update-statut-usager&var-cluster=pg&var-instances=All)
github-advanced-security[bot] commented 3 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

SocialGroovyBot commented 3 months ago

:tada: This PR is included in version 2.173.24 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: