SocialGouv / domifa

Faciliter l'accรจs aux droits pour les personnes sans domicile stable, en simplifiant la gestion de la domiciliation
https://domifa.fabrique.social.gouv.fr
Apache License 2.0
14 stars 10 forks source link

Feat add select multiple #3566

Closed pYassine closed 19 hours ago

sonarcloud[bot] commented 19 hours ago

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required โ‰ฅ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-actions[bot] commented 19 hours ago

๐ŸŽ‰ Deployment for commit 97166bd806c439923cda0c0cc635b19c2b49c13f :

Ingresses - ๐Ÿš€ [https://admin-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/](https://admin-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/) - ๐Ÿš€ [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/) - ๐Ÿš€ [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/admin/structures/export](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/admin/structures/export) - ๐Ÿš€ [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/export](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/export) - ๐Ÿš€ [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/stats](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/stats) - ๐Ÿš€ [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/stats/home](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/stats/home) - ๐Ÿš€ [https://domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/](https://domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/) - ๐Ÿš€ [https://mon-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/](https://mon-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/)
Docker images - ๐Ÿ“ฆ docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-97166bd806c439923cda0c0cc635b19c2b49c13f - ๐Ÿ“ฆ docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-97166bd806c439923cda0c0cc635b19c2b49c13f - ๐Ÿ“ฆ docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-97166bd806c439923cda0c0cc635b19c2b49c13f - ๐Ÿ“ฆ docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-97166bd806c439923cda0c0cc635b19c2b49c13f
Debug - [๐Ÿ“• Loki logs for namespace domifa-feat-add-select-multiple](https://grafana-ovh.fabrique.social.gouv.fr/explore?orgId=1&left=%5B%22now-6h%22,%22now%22,%22Loki%22,%7B%22expr%22:%22%7Bnamespace%3D%5C%22domifa-feat-add-select-multiple%5C%22%7D%22%7D%5D) - [๐Ÿ“ˆ Pods monitoring for namespace domifa-feat-add-select-multiple](https://grafana-ovh.fabrique.social.gouv.fr/d/a7df53d7-0696-4e00-821b-c56b66e5c20a/kubernetes-compute-resources-namespace-pods?orgId=1&refresh=10s&var-datasource=P5DCFC7561CCDE821&var-cluster=ovh-dev&var-namespace=domifa-feat-add-select-multiple) - [๐Ÿ“ˆ Workloads monitoring for namespace domifa-feat-add-select-multiple](https://grafana-ovh.fabrique.social.gouv.fr/d/a164a7f0339f99e89cea5cb47e9be617V2/kubernetes-compute-resources-namespace-workloads?orgId=1&refresh=10s&var-datasource=eb239be0-0ac2-41d5-9e1a-061f951a07a3&var-cluster=ovh-dev&var-namespace=domifa-feat-add-select-multiple&var-type=deployment) - [๐Ÿ˜ CNPG pg](https://grafana-ovh.fabrique.social.gouv.fr/d/z7FCA4Nn1/cloudnativepg?orgId=1&refresh=30s&var-DS_PROMETHEUS=default&var-namespace=domifa-feat-add-select-multiple&var-cluster=pg&var-instances=All)
codecov-commenter commented 19 hours ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.48718% with 64 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (1729c4d) to head (97166bd). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rc/modules/open-data-places/load-data-inclusion.ts 0.00% 6 Missing :warning:
...s/backend/src/modules/open-data-places/load-mss.ts 0.00% 6 Missing :warning:
...end/src/modules/open-data-places/load-soliguide.ts 0.00% 5 Missing :warning:
...ge-usagers-table/manage-usagers-table.component.ts 50.00% 4 Missing and 1 partial :warning:
...ackend/src/modules/open-data-places/load-domifa.ts 0.00% 4 Missing :warning:
...rc/structures/controllers/structures.controller.ts 33.33% 4 Missing :warning:
...ils-senders/cron-mail-user-guide-sender.service.ts 57.14% 3 Missing :warning:
packages/backend/src/run-app.ts 0.00% 3 Missing :warning:
...nd/src/usagers/services/cerfa/get-decision-date.ts 89.28% 3 Missing :warning:
...e/services/monitoring/MonitoringCleaner.service.ts 33.33% 2 Missing :warning:
... and 18 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566/graphs/tree.svg?width=650&height=150&src=pr&token=ydhKiPXRFO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv)](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ```diff @@ Coverage Diff @@ ## master #3566 +/- ## ========================================== + Coverage 66.67% 66.68% +0.01% ========================================== Files 909 917 +8 Lines 15080 15092 +12 Branches 2133 2127 -6 ========================================== + Hits 10054 10064 +10 + Misses 4850 4723 -127 - Partials 176 305 +129 ``` | [Files with missing lines](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | Coverage ฮ” | | |---|---|---| | [packages/backend/src/\_common/model/usager/index.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_common%2Fmodel%2Fusager%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX2NvbW1vbi9tb2RlbC91c2FnZXIvaW5kZXgudHM=) | `100.00% <รธ> (รธ)` | | | [...I\_SECURITY\_STRUCTURE\_CONTROLLER\_TEST\_DEFS.const.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_tests%2FAPI_SECURITY_STRUCTURE_CONTROLLER_TEST_DEFS.const.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX3Rlc3RzL0FQSV9TRUNVUklUWV9TVFJVQ1RVUkVfQ09OVFJPTExFUl9URVNUX0RFRlMuY29uc3QudHM=) | `100.00% <100.00%> (รธ)` | | | [packages/backend/src/app.module.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fapp.module.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvYXBwLm1vZHVsZS50cw==) | `100.00% <100.00%> (รธ)` | | | [...rc/database/entities/usager/UsagerTable.typeorm.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fentities%2Fusager%2FUsagerTable.typeorm.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2UvZW50aXRpZXMvdXNhZ2VyL1VzYWdlclRhYmxlLnR5cGVvcm0udHM=) | `100.00% <รธ> (รธ)` | | | [...ules/contact-support/contact-support.controller.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fmodules%2Fcontact-support%2Fcontact-support.controller.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvbW9kdWxlcy9jb250YWN0LXN1cHBvcnQvY29udGFjdC1zdXBwb3J0LmNvbnRyb2xsZXIudHM=) | `37.03% <100.00%> (-2.25%)` | :arrow_down: | | [...ages/backend/src/modules/interactions/dto/index.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fmodules%2Finteractions%2Fdto%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvbW9kdWxlcy9pbnRlcmFjdGlvbnMvZHRvL2luZGV4LnRz) | `100.00% <รธ> (รธ)` | | | [...d/src/modules/interactions/dto/interactions.dto.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fmodules%2Finteractions%2Fdto%2Finteractions.dto.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvbW9kdWxlcy9pbnRlcmFjdGlvbnMvZHRvL2ludGVyYWN0aW9ucy5kdG8udHM=) | `85.00% <100.00%> (รธ)` | | | [...ractions/interactions.controller.security-tests.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fmodules%2Finteractions%2Finteractions.controller.security-tests.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvbW9kdWxlcy9pbnRlcmFjdGlvbnMvaW50ZXJhY3Rpb25zLmNvbnRyb2xsZXIuc2VjdXJpdHktdGVzdHMudHM=) | `100.00% <100.00%> (รธ)` | | | [...rc/modules/interactions/interactions.controller.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fmodules%2Finteractions%2Finteractions.controller.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvbW9kdWxlcy9pbnRlcmFjdGlvbnMvaW50ZXJhY3Rpb25zLmNvbnRyb2xsZXIudHM=) | `67.56% <100.00%> (รธ)` | | | [...nd/src/modules/interactions/interactions.module.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fmodules%2Finteractions%2Finteractions.module.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvbW9kdWxlcy9pbnRlcmFjdGlvbnMvaW50ZXJhY3Rpb25zLm1vZHVsZS50cw==) | `100.00% <100.00%> (รธ)` | | | ... and [135 more](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | | ... and [59 files with indirect coverage changes](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) > `ฮ” = absolute (impact)`, `รธ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Last update [1729c4d...97166bd](https://app.codecov.io/gh/SocialGouv/domifa/pull/3566?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv).

๐Ÿšจ Try these New Features:

SocialGroovyBot commented 19 hours ago

:tada: This PR is included in version 2.185.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: