SocialGouv / domifa

Faciliter l'accès aux droits pour les personnes sans domicile stable, en simplifiant la gestion de la domiciliation
https://domifa.fabrique.social.gouv.fr
Apache License 2.0
14 stars 10 forks source link

fix(frontend): fix select boxes #3575

Closed pYassine closed 3 days ago

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov-commenter commented 3 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.24299% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (b697eab) to head (58ee490). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...nage-usagers-page/manage-usagers-page.component.ts 0.00% 6 Missing :warning:
...lter/services/usagersSearchStringFilter.service.ts 53.84% 5 Missing and 1 partial :warning:
...kend/src/usagers/controllers/usagers.controller.ts 20.00% 4 Missing :warning:
.../src/_migrations/1731349672897-manual-migration.ts 33.33% 2 Missing :warning:
...tabase/entities/usager/UsagerSubscriber.typeorm.ts 95.45% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575/graphs/tree.svg?width=650&height=150&src=pr&token=ydhKiPXRFO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv)](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ```diff @@ Coverage Diff @@ ## master #3575 +/- ## ========================================== - Coverage 66.68% 66.68% -0.01% ========================================== Files 917 919 +2 Lines 15085 15048 -37 Branches 2130 2116 -14 ========================================== - Hits 10060 10035 -25 + Misses 4986 4709 -277 - Partials 39 304 +265 ``` | [Files with missing lines](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | Coverage Δ | | |---|---|---| | [...ckend/src/\_common/decorators/StripTagsDecorator.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_common%2Fdecorators%2FStripTagsDecorator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX2NvbW1vbi9kZWNvcmF0b3JzL1N0cmlwVGFnc0RlY29yYXRvci50cw==) | `100.00% <100.00%> (ø)` | | | [...ies/contact-support/ContactSupportTable.typeorm.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fentities%2Fcontact-support%2FContactSupportTable.typeorm.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2UvZW50aXRpZXMvY29udGFjdC1zdXBwb3J0L0NvbnRhY3RTdXBwb3J0VGFibGUudHlwZW9ybS50cw==) | `100.00% <100.00%> (+11.76%)` | :arrow_up: | | [.../entities/structure/StructureSubscriber.typeorm.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fentities%2Fstructure%2FStructureSubscriber.typeorm.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2UvZW50aXRpZXMvc3RydWN0dXJlL1N0cnVjdHVyZVN1YnNjcmliZXIudHlwZW9ybS50cw==) | `100.00% <100.00%> (ø)` | | | [...abase/entities/structure/StructureTable.typeorm.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fentities%2Fstructure%2FStructureTable.typeorm.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2UvZW50aXRpZXMvc3RydWN0dXJlL1N0cnVjdHVyZVRhYmxlLnR5cGVvcm0udHM=) | `90.90% <100.00%> (-1.10%)` | :arrow_down: | | [...rc/database/entities/usager/UsagerTable.typeorm.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fentities%2Fusager%2FUsagerTable.typeorm.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2UvZW50aXRpZXMvdXNhZ2VyL1VzYWdlclRhYmxlLnR5cGVvcm0udHM=) | `100.00% <ø> (ø)` | | | [.../user-structure/UserStructureSubscriber.typeorm.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fentities%2Fuser-structure%2FUserStructureSubscriber.typeorm.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2UvZW50aXRpZXMvdXNlci1zdHJ1Y3R1cmUvVXNlclN0cnVjdHVyZVN1YnNjcmliZXIudHlwZW9ybS50cw==) | `100.00% <100.00%> (ø)` | | | [...ities/user-structure/UserStructureTable.typeorm.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fentities%2Fuser-structure%2FUserStructureTable.typeorm.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2UvZW50aXRpZXMvdXNlci1zdHJ1Y3R1cmUvVXNlclN0cnVjdHVyZVRhYmxlLnR5cGVvcm0udHM=) | `100.00% <ø> (ø)` | | | [...ase/services/\_postgres/PG\_CONNECT\_OPTIONS.const.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fservices%2F_postgres%2FPG_CONNECT_OPTIONS.const.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2Uvc2VydmljZXMvX3Bvc3RncmVzL1BHX0NPTk5FQ1RfT1BUSU9OUy5jb25zdC50cw==) | `52.17% <ø> (ø)` | | | [...ackages/backend/src/usagers/dto/create-note.dto.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fusagers%2Fdto%2Fcreate-note.dto.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvdXNhZ2Vycy9kdG8vY3JlYXRlLW5vdGUuZHRvLnRz) | `100.00% <100.00%> (ø)` | | | [...kages/backend/src/usagers/dto/search-usager.dto.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fusagers%2Fdto%2Fsearch-usager.dto.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvdXNhZ2Vycy9kdG8vc2VhcmNoLXVzYWdlci5kdG8udHM=) | `100.00% <ø> (ø)` | | | ... and [16 more](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | | ... and [115 files with indirect coverage changes](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Last update [b697eab...58ee490](https://app.codecov.io/gh/SocialGouv/domifa/pull/3575?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv).
github-actions[bot] commented 3 days ago

🎉 Deployment for commit 58ee4907fda45ad7dea105f16f3f7cc281904505 :

Ingresses - 🚀 [https://admin-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/](https://admin-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/) - 🚀 [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/) - 🚀 [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/admin/structures/export](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/admin/structures/export) - 🚀 [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/export](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/export) - 🚀 [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/stats](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/stats) - 🚀 [https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/stats/home](https://api-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/stats/home) - 🚀 [https://domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/](https://domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/) - 🚀 [https://mon-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/](https://mon-domifa-feat-add-select-multiple.ovh.fabrique.social.gouv.fr/)
Docker images - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-58ee4907fda45ad7dea105f16f3f7cc281904505 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-58ee4907fda45ad7dea105f16f3f7cc281904505 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-58ee4907fda45ad7dea105f16f3f7cc281904505 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-58ee4907fda45ad7dea105f16f3f7cc281904505
Debug - [📕 Loki logs for namespace domifa-feat-add-select-multiple](https://grafana-ovh.fabrique.social.gouv.fr/explore?orgId=1&left=%5B%22now-6h%22,%22now%22,%22Loki%22,%7B%22expr%22:%22%7Bnamespace%3D%5C%22domifa-feat-add-select-multiple%5C%22%7D%22%7D%5D) - [📈 Pods monitoring for namespace domifa-feat-add-select-multiple](https://grafana-ovh.fabrique.social.gouv.fr/d/a7df53d7-0696-4e00-821b-c56b66e5c20a/kubernetes-compute-resources-namespace-pods?orgId=1&refresh=10s&var-datasource=P5DCFC7561CCDE821&var-cluster=ovh-dev&var-namespace=domifa-feat-add-select-multiple) - [📈 Workloads monitoring for namespace domifa-feat-add-select-multiple](https://grafana-ovh.fabrique.social.gouv.fr/d/a164a7f0339f99e89cea5cb47e9be617V2/kubernetes-compute-resources-namespace-workloads?orgId=1&refresh=10s&var-datasource=eb239be0-0ac2-41d5-9e1a-061f951a07a3&var-cluster=ovh-dev&var-namespace=domifa-feat-add-select-multiple&var-type=deployment) - [🐘 CNPG pg](https://grafana-ovh.fabrique.social.gouv.fr/d/z7FCA4Nn1/cloudnativepg?orgId=1&refresh=30s&var-DS_PROMETHEUS=default&var-namespace=domifa-feat-add-select-multiple&var-cluster=pg&var-instances=All)
SocialGroovyBot commented 3 days ago

:tada: This PR is included in version 2.185.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: