SocialiteProviders / Manager

Easily add new or override built-in Laravel Socialite providers
https://socialiteproviders.com/contribute/
MIT License
393 stars 84 forks source link

Register provider listeners not being called after updating to Laravel 6.0 #147

Closed ethanransdellrarebird closed 5 years ago

ethanransdellrarebird commented 5 years ago

Issue / Motivation:

Register provider listeners not being called

Expected behavior:

Socialite::driver('azure')->redirect(); should redirect to the provider's login page

Actual behavior:

InvalidArgumentException with message 'Driver [azure] not supported.'

Steps to reproduce the behavior:

Proposed solution:

I've been troubleshooting and see that in this case, the AzureExtendSocialite listener is not being triggered. I was able to dispatch the event manually in tinker and get a die dump from AzureExtendSocialite but still could not get a redirect.

Clayboy commented 5 years ago

I have the same issue with InstagramExtendSocialite listener.

Debugging with Laravel Telescope, SocialiteWasCalled event is dispatched but no listener are triggered (even if found in php artisan event:list).

Maybe an execution order issue.

Francismori7 commented 5 years ago

Same thing here.

ethanransdellrarebird commented 5 years ago

Found that firing the SocialiteWasCalled event is not being added to the app's booted callbacks. Working on a PR.

m1guelpf commented 5 years ago

Tagged a new release