SofaDefrost / STLIB

Sofa Template Library
GNU Lesser General Public License v3.0
17 stars 22 forks source link

[splib3] Adds features and one fix #116

Closed EulalieCoevoet closed 6 months ago

EulalieCoevoet commented 1 year ago

In numerics:

In animation:

damienmarchal commented 11 months ago

Hi @EulalieCoevoet

Thanks for the PR.

Could you elaborate a bit more the use case for the endTime parameter in animate. It is unclear to me what is its purpose and if its name reflects what it does.

EulalieCoevoet commented 11 months ago

It allows to synchronize and loop multiple animations.

EulalieCoevoet commented 10 months ago

Let's say you have an animation, with a duration of 2s but you want it to play again or rewind every 4s, you'll set :

@damienmarchal What do you think ?

EulalieCoevoet commented 9 months ago

What about endDelay with the corresponding new implementation ?

EulalieCoevoet commented 7 months ago

@damienmarchal I've made the changes and added an exemple :)

EulalieCoevoet commented 6 months ago

@damienmarchal can we merge?

damienmarchal commented 6 months ago

@EulalieCoevoet it is ok to me, i just change the code so the parameter is passed as "duration". If ok to you, you can merge the PR.