SoftCreatR / imei

IMEI - ImageMagick Easy Install
ISC License
309 stars 36 forks source link

imei isn't aware of conflicts during dependency installation and incorrectly displays that dependency installation is complete #28

Closed hparadiz closed 3 years ago

hparadiz commented 3 years ago

🚀 Feature

imei should fail out when there is an apt install failure with a dump of the previous command stdout

Another option is to search for the installed packages from the output of apt list --installed

Have you spent some time to check if this issue has been raised before?

Yes

Have you read the Code of Conduct?

[x] I have read the Code of Conduct

Pitch

imei isn't aware of conflicts during dependency installation and incorrectly displays that dependency installation is complete

The result compile ends up not supporting many image types.

It would be useful to have imei either warn you or prompt you with "Looks like some dependencies are still missing. Would you like to continue with compile?"

Screenshots

image

What actually happens under the hood.

image

SoftCreatR commented 3 years ago

There is actually some kind of a check included and it was planned to let the step "Installing dependencies" fail, if anything goes wrong. Obviously, that doesn't work as expected. I'll try to find a solution.

Btw, it would be helpful, if you could attach the file /var/log/imei.log.

hparadiz commented 3 years ago

Certainly,

https://paste.ubuntu.com/p/Dvh2wBgryX/

SoftCreatR commented 3 years ago

Well, according to the log, there was no problem during the installation of dependencies and even the Delegate library configuration (in the log) differs from the output of identify -version.

Could you please try executing /usr/local/bin/identify -version instead? Because the only thing that comes in my mind is, that IM is installed twice on the system.

hparadiz commented 3 years ago

It compiled fine both times. But the first time it didn't have access to most delegates (see first screenshot in my original post).

Now it shows this: image

The second time it simply overwrote the first one. It's completely fine now.

SoftCreatR commented 3 years ago

So the log file isn't from the failed installation? In this case, I can't really reproduce, what exactly happened.

I'll close this issue then, but I'll keep an eye on it.

hparadiz commented 3 years ago

Just to be clear. It never failed to install or compile. It simply compiled without all the dependencies it needed. The real issue is that imei skips installing dependencies if apt says there was a conflict during dependency installation.

SoftCreatR commented 3 years ago

I understood that. But I can't reproduce this with the logs provided. There is a check included in IMEI that should prevent this kind of failure.