Closed tobyhodges closed 6 years ago
I think that I've somewhat addressed both points in PR #52 . Comments and suggestions are obviously more than welcome.
We can close the issue when the PR is merged.
I think that we still need to move the "Create a project on GitHub" exercise/guide out of make-it-public before we can close this. The question is: do we put it in extras or in the introduction?
In #50, I move it into the introduction. If that gets merged in addition to #52, then I agree that we can close this.
That is a fair point; I agree that it seems better fitted to the introduction so I can merge #50 (I see that it's ready to be merged in any case), and then try to fix the introduction so that the "Create a project" part is at the end of the episode itself. Sounds good?
Sounds good to me :+1:
On 4. Sep 2018, at 13:34, Fotis E. Psomopoulos notifications@github.com wrote:
That is a fair point; I agree that it seems better fitted to the introduction so I can merge #50 https://github.com/SoftDev4Research/4OSS-lesson/pull/50 (I see that it's ready to be merged in any case), and then try to fix the introduction so that the "Create a project" part is at the end of the episode itself. Sounds good?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SoftDev4Research/4OSS-lesson/issues/44#issuecomment-418350065, or mute the thread https://github.com/notifications/unsubscribe-auth/AJPtPJe8Vq1P2hzzdWSO4FVKSA9pwE_Mks5uXnNBgaJpZM4Vtm8B.
Ok, done. If there are no other suggestions/edits, I will be closing this issue.
:+1: thanks, Fotis :)
We didn't discuss what will go into the introductory episode. A couple of thoughts:
extras
or get rid of it entirely and link to another online guide)