search

SoftInstigate / restheart

Rapid API Development with MongoDB
https://restheart.org
GNU Affero General Public License v3.0
805 stars 171 forks source link

ETag header values should be quoted #152

Closed mirzov closed 8 years ago

mirzov commented 8 years ago

Hi! According to RFC 2616, the values of the ETag headers are supposed to be quoted strings. Please see also this answer on StackOverflow. Do you think you could consider complying and changing the RESTHeart responses in future releases?

mkjsix commented 8 years ago

Hello @mirzov It seems to me you are right. Accordingly to RFC 7232 (which supersedes RFC 2621) the ETag must be in quoted strings.

I created a JIRA issue to track progress on this: https://softinstigate.atlassian.net/browse/RH-207

However, I can't give you the ETA right now, we need to prioritize work internally.

mirzov commented 8 years ago

Hello @mkjsix, Thank you for the prompt reaction! The issue is not critical as far as I am concerned (results in warnings by an HTTP-level library). Hope the change will not create problems for your existing user base.

mkjsix commented 8 years ago

Not sure about the impact, but we'd like to stay HTTP compliant as much as possibile. We'll publish the changes on master and then decide when to move to a stable release.

mkjsix commented 8 years ago

Hi @mirzov Unfortunately we have an impact already with our default integration tests, so we do expect regressions. This means we need to schedule this modification for a major release (3.0) as it could probably break clients using 2.x.

mirzov commented 8 years ago

Hi @mkjsix Thanks a lot for letting me know, appreciate your fast feedback!

mkjsix commented 8 years ago

After a deeper analysis this would really require a major refactoring, so we have decided to freeze this activity because we have higher priorities for the product. Technical details are in https://softinstigate.atlassian.net/browse/RH-207