search

SoftwareDefinedBuildings / XBOS

The eXtensible Building Operating System
BSD 2-Clause "Simplified" License
28 stars 18 forks source link

DR Event analysis & RTU dual stage cooling analysis #79

Closed thomson-greg closed 5 years ago

gtfierro commented 5 years ago

There are a lot of hard-coded site names and services names in here. I'm a little uneasy about having those be in the public code. @moustafa-a what do you think?

thomson-greg commented 5 years ago

Hi Gabe,

Yes, I can do that.

cheers!

greg

Gregory D. Thomson, LEED AP Specialist California Institute for Energy and Environment University of California, Berkeley mobile: +1 510.541.8843

On Wed, Jan 16, 2019 at 9:59 AM Gabe Fierro notifications@github.com wrote:

@gtfierro requested changes on this pull request.

Can you remove the IPython checkpoint files from the repository? They will complicate merges later on. Delete the file from the repo and add it to your .gitignore file

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SoftwareDefinedBuildings/XBOS/pull/79#pullrequestreview-193273424, or mute the thread https://github.com/notifications/unsubscribe-auth/AfK3sqKl2KFArj7pOpPJW9y5QfIvNMviks5vD2h-gaJpZM4aBxgg .

gtfierro commented 5 years ago

I'm going to merge this in so that we can use the analytics. I'd like for the site names to not be hardcoded, but ultimately the data is still protected even if the site names are open.