Soluto / helm-charts

Soluto's Helm Charts Repository
MIT License
8 stars 12 forks source link

Kamus-encryptor crashes when attempting to inject a Linkerd 2 sidecar #33

Closed ncthbrt closed 4 years ago

ncthbrt commented 4 years ago

Searching through the chart, I noticed that "automountServiceAccountToken: false" is specified in the encryptor. The service account token is required for correct meshing in Linkerd.

omerlh commented 4 years ago

Thanks for filing this issue! As the service account token is not used in the encryptor, we assumed it's more secure not to mount it. Can you please open a PR and add an option to the chart to allow mounting it? Basically, change the automountServiceAccountToken?

ncthbrt commented 4 years ago

Thanks. I'll do so.