search

Soluto / helm-charts

Soluto's Helm Charts Repository
MIT License
8 stars 12 forks source link

Update kubectl port-forward directions #5

Closed Yitaek closed 5 years ago

Yitaek commented 5 years ago

Currently when you install with default settings (i.e. ClusterIP), Helm helper/notes prints out the following:

export POD_NAME=$(kubectl get pods --namespace default -l "app=kamus,release=kamus" -o jsonpath="{.items[0].metadata.name}")
  echo "Visit http://127.0.0.1:8080 to use your application"
  kubectl port-forward $POD_NAME 8080

POD_NAME defaults to the decryptor component, so to actually use the encryptor component, we can change the POD_NAME to the following instead to specify it:

export POD_NAME=$(kubectl get pods --namespace default -l "app=kamus,release=kamus,component=encryptor" -o jsonpath="{.items[0].metadata.name}")

Also, it seems that {{ .Values.service.internalPort }} does not exist and is instead hardcoded to port 9999, so the kubectl port-forward command should also be updated to

kubectl port-forward $POD_NAME 8080:9999

omerlh commented 5 years ago

Thanks for pointing it out! Your fix makes sense to me, do you want to open a PR?

Yitaek commented 5 years ago

Yup, just submitted a PR (wasn't sure if you had a preferred method for collaboration so just forked for now). Thanks for open sourcing this tool!

omerlh commented 5 years ago

Thank you! If you use it please share the experience with us, we would like to hear - and I will be happy adding a logo on our readme of the users :)