Open martin-strecker-sonarsource opened 2 months ago
We also should mak sure that the cli executables have the same file permissions than what we find in the original dowloaded from jfrog:
We may use ZipEntry ExternalAttributes and this calculation: https://unix.stackexchange.com/questions/14705/the-zip-formats-external-file-attribute
Follow up to #2086 and #2087
In #2086, we documented that the
Compress-Archive
PowerShell command produces invalid zip files. In #2087, we fixed this by using the Windows built-in tooltar.exe
. We also tried:Both attempts failed because the tools in question were not installed on our images. Instead, we used
tar.exe
in #2087 as a quick fix.tar.exe
works fine but we should replace it because:-a
flag, which is undocumented (it isn't listed intar --help
zip
support isn't officially mentioned as wellAll of the points mentioned above will bite us sooner than later. We should settle for a more stable/supported solution. Using 7-zip seems the appropriate choice to avoid the brittle
Compress-Archive
and the obscuretar.exe
. For this, we need to install 7-zip on our ci image (https://github.com/SonarSource/dotnet-ci-images/issues/24).