Closed Suvadip-sana closed 3 weeks ago
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
wanderlust-2024 | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Nov 8, 2024 2:14pm |
Thank you for submitting your pull request! π We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! π
@Soujanya2004 I set the image preview style for 4 image, for both form because in my another issue for set the limitation of the number of image upload, where I am going to set the limit of 4 image.
I think 4 image is enough.
i already sent PR for setting tags.. #419
i already sent PR for setting tags.. #419
@Meetpidev Good but I think you need to create new PR for your ISSUE. Because that time no filter functionality is there. You add dummy. Right?
Also my this ISSUE is for structure the preview image properly #389 You can verify it. But when I start to work on it. Thought that small changes required. Nothing else. You supposed to be add design for filter over this ππ
i already sent PR for setting tags.. #419
i added to select type when creating new listing.... just a frontend part.. also the type is stored in DB.. its not dummy
@Soujanya2004 @Meetpidev
Here already tags feature is there for filter out the listing. So why there is need of genera feature? Is this make any sense to have both feature? I don't think so!
both genre and tags are the same...
i just named it genre inplace of tags.. while i was working ..
i just named it genre inplace of tags.. while i was working ..
both genre and tags are the same...
Yes I said exactly the same. So there is no need to add genera
functionality over Tag
functionality. Because there is already Tag
features there. Hope my perspective is clear?
@Suvadip-sana conflicts please resolve
@Soujanya2004 Solved. Marge it
@Soujanya2004 Hey you missed it's labeling before marge. Please give it labeled as per ISSUE #389
@Soujanya2004 Please add it otherwise it's not count on leaderboard.
Description
I improve the image preview styling of new list add form, along with tags styling with both dark mode and normal mode.
Related Issues
Link any related issues using the format
Fixes #issue_number
. This helps to automatically close related issues when the PR is merged.Screenshots (if applicable)
Add any screenshots that help explain or visualize the changes.
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.
@Soujanya2004 Marge it. And don't forget to add all the labels as per ISSUE #389