Fixed and rewrote opgg plugin

Soundofdarkness / RuneBook

📖 Arcane Rune Pages manager for League of Legends 📜

MIT License

100 stars 21 forks source link

Fixed and rewrote opgg plugin #114

Closed 89Q12 closed 2 years ago

89Q12 commented 2 years ago

Fixed op.gg plugin by rewriting it and I added support for other modes(ARAM, U.R.F)

89Q12 commented 2 years ago

So I think now it should be optimized and good to go :)

Soundofdarkness commented 2 years ago

Looks good so far, going to already merge it, but it might take me a day or two until I can release it, sorry (mentioned why in #105 ). Thank you !

HannoMartinus commented 2 years ago

Couldn't wait for the next release, ended up compiling it myself and it works perfectly. There's one small visual issue though. The scrollbar looks ugly, and I suggest you make it part of the inner box (where the arrow points) Thanks in advance!

89Q12 commented 2 years ago

Hi @HannoMartinus thanks for the feedback, ~I'm aware of this issue and I'm working on it but its in a bigger UI rework. I'm gonna push a fix to my fork, if you want a fix for that and even more unreleased feature check it out meaning build it from source. But as always you can just wait for it to be included in the next release(s)~

Edit: There is actually a scrollbar but for some reason it doesn't work sometimes, try building with node version 15.14.0, this fixed it for me