Soundofdarkness / RuneBook

📖 Arcane Rune Pages manager for League of Legends 📜
MIT License
100 stars 21 forks source link

Trading champions in draft (ranked or normal) doesn't change the runepage #121

Open Elderweiss-was-taken opened 2 years ago

Elderweiss-was-taken commented 2 years ago

When using the feature "Auto select" in the main page and in the Settings page -> Experimental : "Auto-upload favorite page", let's say you pick Yuumi and then you trade champions with a Nasus, and let's assume you have one favorite page set in RuneBook for every champion in the game, instead of applying again the automatic upload for the favorite page of Nasus, it will keep the page of the first champion you pick, which in this example is Yuumi.

So ideally, the method that auto uploads the favorite page should also be called every time that you complete a trade with an ally