search

Soundofdarkness / RuneBook

📖 Arcane Rune Pages manager for League of Legends 📜
MIT License
100 stars 21 forks source link

Fix blitzgg #125

Closed 89Q12 closed 2 years ago

89Q12 commented 2 years ago

Well I fixed the plugin and refactored it while doing so. Looks like the whole item set thingy needs some work

ghost commented 2 years ago

why RANKED_FLEX_SR instead of RANKED_SOLO_5X5? Because the old ranked was also solo and not flex.

89Q12 commented 2 years ago

why RANKED_FLEX_SR instead of RANKED_SOLO_5X5? Because the old ranked was also solo and not flex.

Sorry my bad, I messed that up. Thinking longer about it I think we could add a setting for the default game mode a user wants to query the pages with or we could use the info from the lcu

Soundofdarkness commented 2 years ago

Looks good so far, just seems to show 1-2 things wrong as page names, but I think I can fix this quickly myself. Thanks !