SpaceTradersAPI / api-docs

The API documentation for the SpaceTraders API
143 stars 35 forks source link

Stoplight mock server returns data out of schema #72

Open CollinDietz opened 1 year ago

CollinDietz commented 1 year ago

Attempting to use https://stoplight.io/mocks/spacetraders/spacetraders/96627693 to test my API implementation, but some of the data returned is not parse-able in general, and definitely not parse-able if I want to apply stricter parsing

https://spacetraders.stoplight.io/docs/spacetraders/86ed6bbe4f5d7-register-new-agent

Register responds with this in the agent block

      "agent": {
         "accountId": "string",
         "symbol": "string",
         "headquarters": "string",
         "credits": -9223372036854776000, <-- does not fit in an i64 (-9223372036854775808: int64 min)
         "startingFaction": "string",  <-- not one of the faction enum values
         "shipCount": 0
      },

I see a few other places that do not conform to enum standards, I haven't made it much futher then register at the moment since it is hard to write unit tests around.