SpaceyaTech / SYT-Web-Redesign

https://www.spaceyatech.com/
Apache License 2.0
9 stars 26 forks source link

Integrate new shop apis + bug fixes #229

Closed alvyynm closed 2 months ago

alvyynm commented 3 months ago

Have you read the contributing guidelines ?

What is the purpose of your pull request?

Proposed changes

Resolves #228 by integrating the new shop api to the product detail page.

In addition to that, the PR introduces the following changes:

(From the video below, I've noted some UI issues. I'll fix soon #230. If you notice more, let me know, and I'll add them to #230)

https://github.com/user-attachments/assets/e4080faa-162f-4bdb-994b-ea9e2a10f073

Existing issues I encountered while working with the API

Warning

Please read these points carefully and answer honestly with an X into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syt-web-redesign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 3:34am
alvyynm commented 3 months ago

Hi @sonylomo, this PR is still a WIP.

alvyynm commented 3 months ago

@sonylomo Ready for review now. @JimmyOty I've highlighted some of the issues I've encountered with the API in my notes above, including inaccessible images.