search

SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.
MIT License
1.88k stars 93 forks source link

Snap package working partially and served in the store #449

Closed soumyaDghosh closed 1 year ago

soumyaDghosh commented 1 year ago

Hi, I have made a snap package for your app. In my current testing, it works perfectly fine. I have tried with multiple users. It's very easy to maintain, as it's just a wrapper to the deb package.

https://github.com/soumyaDghosh/webcord-snap

Would you like to have this as an official package? Also, you can directly make a snap package from the electron-builder. https://www.electron.build/configuration/snap.html

EDIT: Also please give me your email id if you want to add you as a collaborator in the snap store.

soumyaDghosh commented 1 year ago

Hii @SpacingBat3 need your help to debug, why screenshare button isn't working and neither giving any error log when pressed. I have found a similar one in your issue list but can't really match

SpacingBat3 commented 1 year ago

@soumyaDghosh have you make sure Discord has permission granted for that in WebCord's settings? Also did you check the logs in DevTools console for any clues?

soumyaDghosh commented 1 year ago

The permission for Desktop Capture is given, but, this is what I got in console when pressed screenshare button

9c6ffc3d3bda8510df1a.js:534 [RTCControlSocket] Sending heartbeat
9c6ffc3d3bda8510df1a.js:534 [RTCControlSocket] Heartbeat ACK received
1137398189125812324:1 Uncaught (in promise) DOMException: Could not start video source
Promise.then (async)
T @ b49fb419de93e53ce1c1.js:7902
(anonymous) @ f4cf7a10f9ec65bdf0c4.js:1322
onClick @ f4cf7a10f9ec65bdf0c4.js:1323
Me @ b49fb419de93e53ce1c1.js:1753
je @ b49fb419de93e53ce1c1.js:1753
(anonymous) @ b49fb419de93e53ce1c1.js:1774
Ur @ b49fb419de93e53ce1c1.js:1774
Gr @ b49fb419de93e53ce1c1.js:1774
(anonymous) @ b49fb419de93e53ce1c1.js:1780
cc @ b49fb419de93e53ce1c1.js:1845
Le @ b49fb419de93e53ce1c1.js:1752
Yr @ b49fb419de93e53ce1c1.js:1776
Kt @ b49fb419de93e53ce1c1.js:1759
Zt @ b49fb419de93e53ce1c1.js:1759
r @ 9c6ffc3d3bda8510df1a.js:563
9c6ffc3d3bda8510df1a.js:534 [RTCControlSocket] Sending heartbeat
9c6ffc3d3bda8510df1a.js:534 [RTCControlSocket] Heartbeat ACK received

I tested this by running the snap in devmode, so, networking and other issues aren't there. Cause the sandbox is removed. But, the snap uses the Ubuntu 22.04 as core.

SpacingBat3 commented 1 year ago

Are you on Wayland? If so, have you installed a package that provides portals for WebRTC PipeWire capturer?

soumyaDghosh commented 1 year ago

In xorg screen sharing is fine. But, in wayland it's making the problems. I was able to find no such package, but I added libwebrtc-audio-processing1. Still it's same. I can confirm, that the package is using portals. Anyway to give you more detailed debugging infos?