CSS Themes broken by discord. (again)

SpidFightFR commented 10 months ago

Acknowledgements

[X] I have checked that there is no other issue describing the same or similar problem that I currently have, regardless if it has been closed or open.
[ ] This bug affects Discord website.
[X] This issue is confirmed to be reproducible when WebCord is packaged on at least all three latest supported Electron major releases.
[ ] This issue is reproducible in Chrome, Chromium or any Chromium-based browser, e.g Brave or Edge (please write in Additional Context which browser you have used if it is neither Chrome nor unmodified Chromium).
[X] There are no fixes done to master which resolves this issue.
[ ] My issue describes one of the unstable and/or not fully implemented features.
[ ] I have found a workaround to mitigate or temporarily fix this issue in affected releases (please write it in Additional context section below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

v27 (default flatpak)

Application version

v4.5.0

Bug description

--add-css-theme flag does nothing: it only displays the dialog window, once selected, webcord doesn't start.

Additional context

There's nothing more to say, i tried to change the rules of flatpak for webcord, but it stopped working.

SpacingBat3 commented 10 months ago

--add-css-theme flag does nothing: it only displays the dialog window, once selected, webcord doesn't start.

This is intended behavior; there should be no extra WebCord instance running after you add CSS theme. It is expected WebCord is already running or you'll start WebCord after you've added a CSS theme.

SpidFightFR commented 10 months ago

--add-css-theme flag does nothing: it only displays the dialog window, once selected, webcord doesn't start.

This is intended behavior; there should be no extra WebCord instance running after you add CSS theme. It is expected WebCord is already running or you'll start WebCord after you've added a CSS theme.

is it normal if it just hangs after selecting the theme ? I must CTRL+C out of webcord...

SpidFightFR commented 10 months ago

my bad, it actually loads for a bit before closing, but the themes don't apply, it's weird...

SpacingBat3 commented 10 months ago

I've noticed that hiding side bar doesn't work either and WebCord's using the same API in Electron to apply any CSS mods in there, so either Electron got another regression (that would be 3rd time in row 😯) or Discord updated stuff like classes breaking themes.

SpacingBat3 commented 10 months ago

(In both cases, #481 is probably related to this as well.)

SpacingBat3 commented 10 months ago

Yep, Discord most likely just broke most CSS themes just by changing the hypen to underscore in names of the CSS classes. I'll close this issue ticket since that's not WebCord's fault.

SpidFightFR commented 10 months ago

More info here: https://www.reddit.com/r/BetterDiscord/comments/17g1o4o/announcement_from_betterdiscord_discord/

SpacingBat3 / WebCord