Update Check doesn't work for Windows Versions of Webcord

SpacingBat3 / WebCord

A Discord and SpaceBar :electron:-based client implemented without Discord API.

MIT License

1.88k stars 93 forks source link

Update Check doesn't work for Windows Versions of Webcord #484

Open dreamsyntax opened 10 months ago

dreamsyntax commented 10 months ago

Description

The Linux versions of WebCord have a notification that appears a new version of WebCord is available. The Windows versions of WebCord, ex WebCord-win32-x64-4.5.0.zip do not have this popup when a new version is released.

Suggestions

Add a notification like the Linux versions of WebCord to inform the user when an update is available.

Example of Linux:

SpacingBat3 commented 10 months ago

I think this is actually more a bug than lack of implementation. I honestly dunno why this works differently on Windows, but since it seems the entire update check is failing, I would blame the net API in Electron for returning an info that there's no network connection (since this prevents from check to happen at the first place) or failures around fetch API.

I'll probably add some verbose logging to it and test it on Windows.