SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
580 stars 353 forks source link

Site filter on Exceptions List page doesn't save it's state consistently #6018

Open JRichmond27 opened 2 months ago

JRichmond27 commented 2 months ago

Description

When selecting a Site in the filters on the Exception List page, it is not consistently saving the selection for the next time I return to the page. Selecting specific sites seems to work normally, but if selecting "All" causes it to rever to whichever specific site was selected the previous time I filtered the list.

image

A secondary (likely related issue) is that even though selecting All does filter the list correctly initially, the Enabled Filters list at the top of the grid does not update to show that All was selected. instead it still shows the previously selected site.

Actual Behavior

Selecting a specific site in the filter will cause the list to be filtered by that same site the next time I return to the page, but selecting "All" will cause the list to be filtered by the specif site I selected the previous time I filtered the list.

Expected Behavior

Selecting "All" in the filter should cause the list to show exceptions for all sites the next time I return to the Exception List page.

Steps to Reproduce

  1. Go to the Exceptions List page
  2. Open the Filter Options area and select any specific site in the Site dropdown and click Apply Filter
  3. Notice that the Enabled Filters shows the correct site that you selected and that the list of exceptions has been filtered correctly
  4. Go to any other page in Rock and then navigate back to the Exception List page
  5. Notice that the list is still filtered correctly by the specific site you selected. Good so far...
  6. Open the Filter Options, select All in the Site dropdown and click Apply Filter
  7. Notice that the list of exceptions is correctly showing all exceptions, but the Enabled Filters still shows the specific site you selected previously in step 2.
  8. Go to any other page in Rock and then navigate back to the Exception List page
  9. Notice that the list is now filtered by the site you selected in step 2 instead of showing all exceptions as would be expected.

Issue Confirmation

Rock Version

16.6

Client Culture Setting

en-US