Workflow Form: Address Field Validation

sfdts commented 1 month ago

Description

An attribute marked as required on a workflow form using a field of type Address Field is not having proper validation performed. The state sub-field in this automatically has a selection and it appears to have the validation group thinking that this field is indeed saturated/filled out when it is now. This is allowing an empty address with just a state to be submitted.

Actual Behavior

I am able to submit the form with the address field as required and only a state is selected (which is selected by default).

Expected Behavior

If an address field is required, I would expect that an actual complete address must be provided. Furthermore it should stop submission of a form if the address is not provided.

Steps to Reproduce

Create a new workflow type
Add an attribute for address
Create a form action and mark the new address field as visible, editable and required
Launch the workflow to view the form
Attempt to submit with only a state field selected

Example Workflow (for importing)

The boolean show logic in this is not necessary to reproduce this issue. Test Address_202410070637.json

Issue Confirmation

[X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
[X] Reproduced the problem on a fresh install or on the demo site. This appeared to not be an issue in 16.2 on the demo site.

Rock Version

16.6

Client Culture Setting

en-US

chead4 commented 1 month ago

@sfdts Hi Steven - Thanks for sharing the workflow for this issue. I tried to recreate it on both the demo site (v16.6) and prealpha, but haven't had any luck. Could you provide a bit more detail or check if you're able to recreate it on the demo site?

sfdts commented 1 month ago

@chead4 My apologies on this one. I failed to notice that in my example case there were changes to the defined values of the Countries defined type that had every field marked optional. I do not believe this is a valid bug report anymore and I am going to close this issue.

chead4 commented 1 month ago

@sfdts No problem at all! Thanks for getting back to me Steven.

SparkDevNetwork / Rock