search

SpatialHackathon / SpaceHack2023

MIT No Attribution
16 stars 3 forks source link

Bass & maple variable defintion issue #224

Closed Jieran-S closed 9 months ago

Jieran-S commented 9 months ago

https://github.com/SpatialHackathon/SpaceHack2023/blob/57c47102da861408f946d00ab9b611a2a77eced4/method/bass/bass.r#L174-L179 and https://github.com/SpatialHackathon/SpaceHack2023/blob/57c47102da861408f946d00ab9b611a2a77eced4/method/bass/bass.r#L100-L107

Hi, since we changed the matrix option of the optargs file of bass from counts to dim_red, the variable matrix_file is not defined anymore (see code chunk 2). This leads to variable-not-found errors in code chunk 1. Could we fix this by adding:

if (!exists("matrix_file")) {
    matrix_file <- NA
}

or simply delete line 178? @shdam

maple is the same!!