search

SpecFlowOSS / SpecFlow.Actions

BSD 3-Clause "New" or "Revised" License
57 stars 53 forks source link

[Playwright] expose `IConfiguration` of specflow.actions.json #62

Open 304NotModified opened 2 years ago

304NotModified commented 2 years ago

We like to add some additional properties to specflow.actions.json

But currently it seems we have to (re-read) in our own code specflow.actions.json then.

Please expose the IConfiguration - or make it possible to inject.

DomZZ commented 2 years ago

I drop my own browser implementation to use yours (to standardize development and get the opportunity to have new features from you and the OSS community). But when you are in rush and really need a feature, you need to have the possiblity to quickly integrate it without waiting that specflow or someone else implement it.

TechWatching commented 2 years ago

A linked topic would be to be able to add secrets in the configuration provided by the secrets.json file or by a KeyVault.

SabotageAndi commented 2 years ago

We changed SpecFlow.Actions.Configuration to use the standard ConfigurationBuilder. You can access it via ISpecFlowActionsConfiguration. There is no schema on the specflow.actions.json so you can add your properties where you like.

Is this enough @304NotModified?