Using standard Delphi conditional define instead of custom

Spelt / ZXing.Delphi

ZXing Barcode Scanning object Pascal Library for Delphi VCL and Delphi Firemonkey

Apache License 2.0

471 stars 206 forks source link

Using standard Delphi conditional define instead of custom #140

Closed schnider-ru closed 1 year ago

schnider-ru commented 1 year ago

By using the standard conditional define, there is no need to define custom in every project that uses ZXing

Spelt commented 1 year ago

Thanks!

Spelt commented 1 year ago

Unfortunately I had to remove it due to build errors. Maybe you can check it? A quick look discovered more USE_VCL_BITMAP usages.

schnider-ru commented 1 year ago

Made a new PR

Spelt commented 1 year ago

Ok I tested it but still build errors: They are happening in the DUnitXTestProject, LeakTestProject. [dcc32 Error] Test.pas(1246): E2010 Incompatible types: 'Vcl.Graphics.TBitmap' and 'FMX.Graphics.TBitmap'

FMXTestproject [DCC Fatal Error] ZXing.ScanManager.pas(11): F2613 Unit 'VCL.Graphics' not found.

The best to test is with the solution -> Build all, after that make sure the UnitTest project is giving the greens everywhere.

schnider-ru commented 1 year ago

It's all building now