Applying 2 rule of optimisation the previous find_merge was reinstated.
The optimised method was renamed find_merge_optimised and also includes some log methods.
Is is currently not used.
Applying the third rule of optimisation extra extra test where added / activated
existing generate_routing_compression_checker_report can now be activated with cfg
"Mapping", "run_compression_checker"
[Mapping] "router_table_compress_as_far_as_possible" and "run_compression_checker" are now both set true if
[Mode] mode = Debug
spynnaker_integration_tests/test_onchip_compressor
cfg changed to [Mode] mode = Debug
(Without the find_merge change this called some of these tests to fail)
while doing that I fixed some other bugs relating to debug
The confusing and overused cfg settings
write_routing_table_reports and write_routing_tables_from_machine_reports
have been replaced with
write_uncompressed
write_compressed
write_compression_comparison
write_compression_summary
There is a warning if the old cfg settings exist and are false or an Error if they where True (or in debug mode)
The routing_table_from_machine_report removed as it did the exact same thing as router_report_from_compressed_router_tables
All the reading, checking and reporting of routing tables is now OFF by default!
coverage: 47.241% (-0.06%) from 47.305%
when pulling 74069ddae430b9cbae491e40b4adca48858bc24f on Compressor_error
into 135e374cd4ec5a5f105964e8d4087dd3fde19f06 on master.
Patches https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/issues/1180
Applying 2 rule of optimisation the previous find_merge was reinstated.
The optimised method was renamed find_merge_optimised and also includes some log methods. Is is currently not used.
Applying the third rule of optimisation extra extra test where added / activated existing generate_routing_compression_checker_report can now be activated with cfg "Mapping", "run_compression_checker"
[Mapping] "router_table_compress_as_far_as_possible" and "run_compression_checker" are now both set true if [Mode] mode = Debug
spynnaker_integration_tests/test_onchip_compressor cfg changed to [Mode] mode = Debug (Without the find_merge change this called some of these tests to fail)
The confusing and overused cfg settings write_routing_table_reports and write_routing_tables_from_machine_reports have been replaced with
There is a warning if the old cfg settings exist and are false or an Error if they where True (or in debug mode)
The routing_table_from_machine_report removed as it did the exact same thing as router_report_from_compressed_router_tables
All the reading, checking and reporting of routing tables is now OFF by default!
Related PRs tested together. https://github.com/SpiNNakerManchester/SpiNNMachine/pull/259 https://github.com/SpiNNakerManchester/IntegrationTests/pull/268
Tested by: https://github.com/SpiNNakerManchester/sPyNNaker/pull/1446/