search

SpiNNakerManchester / spalloc_server

A SpiNNaker machine allocation and partitioning application.
0 stars 2 forks source link

Protocol change #16

Closed dkfellows closed 7 years ago

dkfellows commented 7 years ago

This PR alters the Spalloc protocol so that higher-level exceptions (i.e., not message envelope decoding failures!) cause a new kind of response message:

{"exception": "the message describing the error that happened"}

(This is in addition to the call, return and notification messages already sent.)

This means that most failures due to passing wrong arguments (as opposed to failures due to bogus network handling or message serialization, either of which would be a direct spalloc client failure) can be represented as exceptions to the callers of the client, making higher-level failures significantly easier to debug.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.002%) to 99.348% when pulling e01b23f59608d79753180a3ed21241fc05188ca8 on protocol-change into be2d8c4180e8e8505313735bf1afee426365e457 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.002%) to 99.348% when pulling d87b4eb2e7eecc88dc63f2d66fc54569d64e571e on protocol-change into be2d8c4180e8e8505313735bf1afee426365e457 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.05%) to 99.954% when pulling c5bf07a679dbfe16c446185763f79466897c93bd on protocol-change into 0d41015502e8d11abf3c879f14cbe933a8f183b9 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ce051dfb6329151b274d51e847fc48ba91f3d247 on protocol-change into 0d41015502e8d11abf3c879f14cbe933a8f183b9 on master.