Delayed free - Githubissues

SpiNNakerManchester / spalloc_server

A SpiNNaker machine allocation and partitioning application.

0 stars 2 forks source link

Delayed free #41

Closed rowleya closed 4 years ago

rowleya commented 6 years ago

This delays the freeing of a machine for (by default) 30 seconds after the board power has been turned off. This passes tests, but could do with some testing to verify that it does actually work!

coveralls commented 6 years ago

Coverage decreased (-0.07%) to 98.584% when pulling 23cb4c01ccb01dec1f8a82e58355b1b438d9bb94 on delayed_free into 8d3b938b13325d5806a528088cafa0403f5b7ffd on master.

rowleya commented 6 years ago

Some simple testing done on a 24-board machine:

ran several 3 board jobs and it did indeed move around the machine until 30 seconds were up, after which the first 3 boards were used again.
ran a 3 board job followed by a 24 board job followed by a 3 board job and second and third jobs were queued until 30 seconds were up
ran 24 board job followed by a 3 board job which was then cancelled followed by another 3 board job. The last job waited until 30 seconds were up as expected.

Quite happy that this now works...

lplana commented 6 years ago

I had a look at the code changes.

Given my limited python grasp I don't follow everything, but I understand the basic ideas and I think that they are correct.

The tests seem to cover the cases that I can think of, so I'm happy for this pull request to be merged.

rowleya commented 4 years ago

This has been outstanding for a while; having merged master and discussed it, I will now merge it!