SpikeHD / Dorion

Tiny alternative Discord client with a smaller footprint, snappier startup, themes, plugins and more!
https://spikehd.github.io/projects/dorion/
GNU General Public License v3.0
631 stars 20 forks source link

[Bug] Client theming broken with `Command get_theme not found` error #260

Closed headquarter8302 closed 1 month ago

headquarter8302 commented 1 month ago

Describe the bug After the 6.1.0 update, theme selection does not work anymore. Picking a theme doesn't do anything, and after closing the settings popup, it'll remove the theme from the options dropdown. Restarting/reopening the client fixes this.

To Reproduce Steps to reproduce the behavior:

  1. Open the client.
  2. Go to settings, Dorion section, Themes tab.
  3. Pick a theme

System Info (please complete the following information):

Additional context/Screenshots This error pops up in the logs when selecting a theme:

Uncaught (in promise) Command get_theme not found
Full session log: ```js 05:39:24.307 Waiting for definition... 05:39:24.310 shelter shelter is initializing... 05:39:24.326 imported 05:39:24.380 Equicord PluginManager Starting plugins (stage Init) 05:39:24.380 Equicord PluginManager Starting plugin NoTrack 05:39:24.395 [FAST CONNECT] wss://gateway.discord.gg/?encoding=json&v=9&compress=zlib-stream, encoding: json, version: 9 05:39:24.396 @me:48 [Deprecation] -ms-high-constrast is in the process of being deprecated. Please see https://blogs.windows.com/msedgedev/2024/04/29/deprecating-ms-high-contrast/ for tips on updating to the new Forced Colors Mode standard. 05:39:24.396 @me:48 [Deprecation] -ms-high-constrast is in the process of being deprecated. Please see https://blogs.windows.com/msedgedev/2024/04/29/deprecating-ms-high-contrast/ for tips on updating to the new Forced Colors Mode standard. 05:39:24.516 Equicord WebpackInterceptor Found Webpack module factory web.6b75845778d0c9b22c40.js 05:39:24.824 Equicord WebpackInterceptor Main Webpack found in web.6b75845778d0c9b22c40.js, initializing internal references to WebpackRequire 05:39:24.824 Equicord WebpackInterceptor Patching webpackChunkdiscord_app.push 05:39:24.977 web.6b75845778d0c9b22c40.js:12 [ProcessUtilsElectron] setMemoryInformation not available. 05:39:25.177 web.6b75845778d0c9b22c40.js:12 [default] [BUILD INFO] Release Channel: ptb, Build Number: 331933, Version Hash: adb00a30d22db9731e02097a63c76566da004a07 05:39:25.178 web.6b75845778d0c9b22c40.js:12 AppCrashedFatalReport: getLastCrash not supported. 05:39:25.318 Equicord NoTrack Disabling Sentry by erroring its WebpackInstance 05:39:25.318 VencordWeb:58 Uncaught Error: Sentry successfully disabled at Function.set (VencordWeb:58:19851) at sentry.f8f0fe362c3ae5c8f4a8.js:453:37896 at sentry.f8f0fe362c3ae5c8f4a8.js:453:38435 05:39:25.319 Equicord PluginManager Starting plugins (stage DOMContentLoaded) 05:39:25.332 Patching postMessage... 05:39:25.332 Stopping here, we are in an iframe! 05:39:25.335 %cshelter%c background: linear-gradient(180deg, #2A3B4B 0%, #2BFAAC 343.17%); color: white; padding: 6px; border-radius: 4px; shelter is initializing... 05:39:25.341 imported 05:39:25.353 %c Equicord %c %c PluginManager background: #a6d189; color: black; font-weight: bold; border-radius: 5px; background: #a6d189; color: black; font-weight: bold; border-radius: 5px; Starting plugins (stage Init) 05:39:25.353 %c Equicord %c %c PluginManager background: #a6d189; color: black; font-weight: bold; border-radius: 5px; background: #a6d189; color: black; font-weight: bold; border-radius: 5px; Starting plugin NoTrack 05:39:25.354 VencordWeb:1345 Uncaught TypeError: Cannot read properties of undefined (reading 'addChangeListener') 05:39:25.354 %c Equicord %c %c PluginManager background: #a6d189; color: black; font-weight: bold; border-radius: 5px; background: #a6d189; color: black; font-weight: bold; border-radius: 5px; Starting plugins (stage DOMContentLoaded) 05:39:25.355 [Create LocalStorage] Done! 05:39:25.356 __TAURI__ defined! 05:39:25.356 IPC custom protocol failed, Tauri will now use the postMessage interface instead TypeError: Cannot read properties of undefined (reading 'json') at VencordWeb:2:1205 at Generator.next () at VencordWeb:1:569 at new Promise () at c (VencordWeb:1:389) at L.window.fetch (VencordWeb:2:790) at Object.sendIpcMessage (:73:7) at Object. (:132:38) at action (:269:38) at :278:11 (anonymous) @ unknown 05:39:25.358 @me:45 [FAST CONNECT] connected in 963ms 05:39:25.372 Equicord MessageLoggerEnhanced hii. no point in checking DataStore if. we already did up there ^^ 05:39:25.882 web.6b75845778d0c9b22c40.js:12 [DEPRECATED] Please use `subscribeWithSelector` middleware a @ web.6b75845778d0c9b22c40.js:12 05:39:26.053 web.6b75845778d0c9b22c40.js:12 [GatewaySocket] [CONNECT] wss://gateway.discord.gg, encoding: json, version: 9, compression: zlib-stream 05:39:26.053 web.6b75845778d0c9b22c40.js:12 [GatewaySocket] [FAST CONNECT] successfully took over websocket, state: Object 05:39:26.053 web.6b75845778d0c9b22c40.js:12 [GatewaySocket] [CONNECTED] wss://gateway.discord.gg/?encoding=json&v=9&compress=zlib-stream in 0 ms 05:39:27.714 web.6b75845778d0c9b22c40.js:12 [GatewaySocket] [READY] took 1660ms, as b513b05c5a1b6574c81b8c4c6f2e0c88 05:39:27.756 web.6b75845778d0c9b22c40.js:12 [Flux] Dispatching CONNECTION_OPEN 05:39:27.761 web.6b75845778d0c9b22c40.js:12 [DatabaseManager] removing database (user: 511031110076203018, database: undefined) 05:39:27.829 Equicord PluginManager Starting plugins (stage WebpackReady) 05:39:27.829 Equicord PluginManager Starting plugin BadgeAPI 05:39:27.829 Equicord PluginManager Starting plugin SupportHelper 05:39:27.829 Equicord PluginManager Starting plugin AlwaysExpandRoles 05:39:27.829 Equicord PluginManager Starting plugin MessageLinkEmbeds 05:39:27.830 Equicord PluginManager Starting plugin WebContextMenus 05:39:27.830 Equicord PluginManager Starting plugin WebKeybinds 05:39:27.830 Equicord PluginManager Starting plugin BannersEverywhere 05:39:27.844 web.6b75845778d0c9b22c40.js:12 [GatewaySocket] [READY_SUPPLEMENTAL] took 1791ms 05:39:28.556 VM564:581 [Theme Loader] Appending Client Mod Styles 05:39:28.557 VM564:5 Discord is loaded! 05:39:28.724 shelter shelter is initialized. took: 4413.2ms 05:39:28.907 VM564:1 [Ensure Plugins] Loading plugin: Dorion Notifications 05:39:28.909 VM564:1 [Ensure Plugins] Loading plugin: Dorion Fullscreen 05:39:28.911 VM564:1 [Ensure Plugins] Loading plugin: Dorion Updater 05:39:28.912 VM614:244 [Updater] Checking for updates... 05:39:28.958 VM564:1 [Ensure Plugins] Loading plugin: Dorion PTT 05:39:28.973 VM564:1 [Ensure Plugins] Loading plugin: Dorion Streamer Mode 05:39:28.974 VM564:1 [Ensure Plugins] Loading plugin: Dorion Custom Keybinds 05:39:28.981 VM564:1 [Ensure Plugins] Loading plugin: Always Trust 05:39:28.982 VM564:1 [Ensure Plugins] Loading plugin: Dorion Tray 05:39:29.116 VM564:1 [Ensure Plugins] Loading plugin: Dorion Settings 05:39:29.771 VM614:252 [Updater] Dorion things to update: 05:39:29.782 VM614:278 Uncaught (in promise) TypeError: event.once is not a function at eval (eval at (eval at (:2:701)), :278:11) at Generator.next () at fulfilled (eval at (eval at (:2:701)), :36:26) 05:39:29.819 7dff18d046a6d2ab5804.js:1 Object 05:39:30.257 coltong.png:1 Failed to load resource: the server responded with a status of 404 () 05:39:30.257 Artboard_1.png:1 Failed to load resource: the server responded with a status of 404 () 05:39:32.638 VM641:4232 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'map') at Object.eval [as fn] (eval at (eval at (:2:701)), :4232:75) at si (VencordWeb:17:12311) at He (VencordWeb:17:12096) at P (VencordWeb:17:7183) at Object.eval [as fn] (eval at (eval at (:2:701)), :4232:51) at si (VencordWeb:17:12311) at He (VencordWeb:17:12096) at Ht (VencordWeb:17:13613) at hi (VencordWeb:17:14481) at Ha (VencordWeb:17:13884) 05:39:34.576 VencordWeb:17 Uncaught TypeError: Cannot read properties of null (reading 'map') at Object.eval [as fn] (eval at (eval at (:2:701)), :4232:75) at si (VencordWeb:17:12311) at He (VencordWeb:17:12096) at Ht (VencordWeb:17:13613) at hi (VencordWeb:17:14481) at Ha (VencordWeb:17:13884) at se (VencordWeb:17:13796) at fi (VencordWeb:17:11777) at r (VencordWeb:17:6588) at setSettings (eval at (eval at (:2:701)), :4194:7) 05:39:44.196 VM641:66 Uncaught (in promise) Command get_theme not found 05:39:47.727 @me:1 [Deprecation] -ms-high-constrast is in the process of being deprecated. Please see https://blogs.windows.com/msedgedev/2024/04/29/deprecating-ms-high-contrast/ for tips on updating to the new Forced Colors Mode standard. 05:39:47.729 @me:1 [Deprecation] -ms-high-constrast is in the process of being deprecated. Please see https://blogs.windows.com/msedgedev/2024/04/29/deprecating-ms-high-contrast/ for tips on updating to the new Forced Colors Mode standard. 05:39:47.729 @me:1 [Deprecation] -ms-high-constrast is in the process of being deprecated. Please see https://blogs.windows.com/msedgedev/2024/04/29/deprecating-ms-high-contrast/ for tips on updating to the new Forced Colors Mode standard. 05:39:47.830 @me:1 [Deprecation] -ms-high-constrast is in the process of being deprecated. Please see https://blogs.windows.com/msedgedev/2024/04/29/deprecating-ms-high-contrast/ for tips on updating to the new Forced Colors Mode standard. 05:39:56.300 VM641:66 Uncaught (in promise) Command get_theme not found rejected @ VM641:66 Promise.then step @ VM641:69 eval @ VM641:70 __async @ VM641:54 deprecated_loadTheme @ VM641:4096 onChange @ VM641:4268 eval @ VM641:290 handleMouseUp_ @ unknown ```
SpikeHD commented 1 month ago

This is due to me leaving in some deprecated old theme stuff for people on v6.0.x, but seeing as that doesn't even seem to work right most of the time, I've just removed it. It should work fine from now on 👍