search

SpikeInterface / spikeinterface

A Python-based module for creating flexible and robust spike sorting pipelines.
https://spikeinterface.readthedocs.io
MIT License
533 stars 187 forks source link

Refactoring auto_merge #3435

Closed yger closed 4 weeks ago

yger commented 2 months ago

This PR is made because of @samuelgarcia request. It will ease the design of recursive auto_merging functions, requiered by SC2 and better methods of automated merging. The idea is that one can provide preset (as before), and params are exposed as dictionary in auto_merges. The old behavior get_potential_auto_merges() is kept, but under the hood, we are now calling the new fonction. The fonction is based as much as possible on extensions.

yger commented 1 month ago

Forget what I said @samuelgarcia , I found the bug in the other PR, this one is working fine and good to merge on my side

samuelgarcia commented 1 month ago

@alejoe91 this is OK for me.