search

SpongePowered / SpongeForge

A Forge mod that implements SpongeAPI
http://www.spongepowered.org/
MIT License
1.14k stars 306 forks source link

Ongoing Minor Issue List (SpongeForge Edition) #263

Open Deamon5550 opened 9 years ago

Deamon5550 commented 9 years ago

SpongeAPI | SpongeCommon | SpongeForge | SpongeVanilla

A new and improved Minor issue list for Beta. This list will be handled a little differently in order to make it much clearer whether a reported issue has been noted and/or fixed. Minor issues reported here will be added to the main comment and the reporting comment will be deleted. Checkstyle issues should not be reported here as those can be more accurately determined by simply running the checkstyle tool. Examples of good issues to report here are misnamed methods/fields, poorly worded javadocs, minor logical errors (like that something could be using a java8 stream).

Minor Issue List

liach commented 6 years ago

https://github.com/SpongePowered/SpongeForge/commit/e37fa119fa73a9a2819ad68a0d9ff8bb436f0459#diff-58e0014cf676b44128730ca938af8f0dR135 Should be SERVER_THREAD instead.

LordRalex commented 5 years ago

https://github.com/SpongePowered/SpongeForge/blob/6d0ee2e4e438b86a3e7051bbfea16fca16554eea/src/main/java/org/spongepowered/mod/mixin/core/fml/common/MixinLoader.java#L90

This should be just referring to SpongeLaunch.getAdditionalPluginsDir() which has the same logic

JBYoshi commented 5 years ago

https://github.com/SpongePowered/SpongeForge/blob/76122437fa53e352024f14372f73fa28fad452e1/src/main/java/org/spongepowered/mod/mixin/core/fml/common/eventhandler/MixinEventBus.java#L160

Typo in "initialied"; missing a Z.