search

SpongePowered / SpongeGradle

Handy gradle utilities for the various gradle projects of SpongePowered
MIT License
21 stars 16 forks source link

Ore Deploy plugin #9

Closed windy1 closed 6 years ago

windy1 commented 7 years ago

Corresponding Ore branch: https://github.com/SpongePowered/Ore/tree/feature/gradle-deploy

Signed-off-by: Walker Crouse walkercrouse@hotmail.com

simon816 commented 7 years ago

Am I right in thinking that we were going to have a maven deploy endpoint on Ore? (i.e. running an uploadArchives task)

Is this gradle integration a replacement for that or just a 'filler' before full maven support is added? Edit: or in addition to maven support?

windy1 commented 7 years ago

@simon816 I think maven support could potentially be built on top of this, but I wanted something that just hooked into the current system as well for simplicity's sake. Working maven into the current file system is a much larger undertaking.

windy1 commented 7 years ago

@Minecrell Can you think of anything else before this goes in?

stephan-gh commented 7 years ago

@windy1 Not right now, but if you don't mind waiting until tomorrow I'd still like to look at some of the Gradle implementation details.

windy1 commented 7 years ago

Sure, no problem. 👍

Asherslab commented 6 years ago

This looks like an absolutely awesome thing, is this ready to go? I'd love to see this soon

windy1 commented 6 years ago

@Asherslab It was working last time I tested it, could probably be improved upon, but could probably go in.

Asherslab commented 6 years ago

Sounds awesome! I could really use this whenever it gets merged in. Thanks for the work!

Asherslab commented 6 years ago

So, i take it this just needs a review from someone else to get merged? (If there's anyway i can use it now that'd be cool too, but either way) 😄

windy1 commented 6 years ago

@Asherslab Essentially, you can build the project yourself if you're like to use it. Should work.

Asherslab commented 6 years ago

Hi @windy1, thanks, i successfully built it myself just after i sent that (sorry)

i do have a bit of an error though, and i'm not sure if that's my fault or a bug:

~~Gradle Error: https://gist.github.com/Asherslab/a7b357a2e58becace55eca2dc292f4e6 build.gradle (With sensitive info removed): https://github.com/Minecolonies/Rankup/blob/API-6/feature/concurrant-tracks/build.gradle (I also tried adding the line oreDeploy.instanceUrl = "https://ore.spongepowered.org/Asherslab/Rankup" incase that was part of the error)~~

EDIT: I just realised that I'm an idiot and didn't add the apache client dependency to my build.gradle! learning learning, sorry for the trouble

i would post this as an issue in your fork, but you don't have an issues tab there. and i feel like making an issue for a non-merged PR here wouldn't be okay (Feel free to tell me to make an issue here 😄 )

Thanks for your work!